Review Request 110672: Allow multiple selection in archiveview

[Alim Gokkaya]

> On Sept. 5, 2014, 1:02 a.m., Raphael Kubo da Costa wrote:
> > part/archivemodel.cpp, line 994
> > <https://git.reviewboard.kde.org/r/110672/diff/4/?file=307167#file307167line994>
> >
> >     Aren't you basically doing this?
> >     
> >     1. Get length of the shortest string in `files`.
> >     2. Start reducing all strings from 1..shortestLength to '' until you find a substring that's common to all of them.
> >     
> >     If I understood what you're trying to do correctly I think your code can be trimmed down.

That's right but I had to check if the selected file is a directory inside the loop. And I handled getting the shortest string in the list in the same loop because it's not guaranteed that `files.at(0)` is the smallest one. I suppose it's not doing something unnecessary but I don't know how it could be done simpler.


- Alim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110672/#review65811
-----------------------------------------------------------


On Sept. 6, 2014, 5:54 p.m., Alim Gokkaya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110672/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2014, 5:54 p.m.)
> 
> 
> Review request for KDE Utils, Albert Astals Cid and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch enables extracting multiple files using drag&drop by removing the code that singles the selection.
> 
> 
> Diffs
> -----
> 
>   part/part.cpp b4ebcd2 
>   part/test/CMakeLists.txt PRE-CREATION 
>   part/test/archivemodeltest.cpp PRE-CREATION 
>   part/CMakeLists.txt 9e38443 
>   part/archivemodel.h 7f8c527 
>   part/archivemodel.cpp 4326268 
>   part/archiveview.cpp 6b9918d 
>   part/part.h 5379b9f 
> 
> Diff: https://git.reviewboard.kde.org/r/110672/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alim Gokkaya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140906/8676986e/attachment-0001.html>