Review Request 110672: Allow multiple selection in archiveview

[Alim Gokkaya]

> On Sept. 5, 2014, 1:02 a.m., Raphael Kubo da Costa wrote:
> > part/archivemodel.h, line 79
> > <https://git.reviewboard.kde.org/r/110672/diff/4/?file=307166#file307166line79>
> >
> >     Same thing about keeping an extra line. And the coding style is slightly off (can't blame you though, there's some inconsistency above).
> >     
> >     Per kdelibs's coding style, the "&" should be next to `files`. By the way, you can use a `QVariantList` here.

Sorry about the code style. I'm using astyle for kdelibs right now.


> On Sept. 5, 2014, 1:02 a.m., Raphael Kubo da Costa wrote:
> > part/test/archivemodeltest.cpp, line 4
> > <https://git.reviewboard.kde.org/r/110672/diff/4/?file=307171#file307171line4>
> >
> >     Why not just include QtDate?

It's funny that even that I include it :)


> On Sept. 5, 2014, 1:02 a.m., Raphael Kubo da Costa wrote:
> > part/CMakeLists.txt, line 16
> > <https://git.reviewboard.kde.org/r/110672/diff/4/?file=307165#file307165line16>
> >
> >     Why isn't it possible to use `arkpart`?

I didn't know how to use kparts properly. I've got rid of this in the last diff.


> On Sept. 5, 2014, 1:02 a.m., Raphael Kubo da Costa wrote:
> > part/test/archivemodeltest.cpp, line 46
> > <https://git.reviewboard.kde.org/r/110672/diff/4/?file=307171#file307171line46>
> >
> >     This causes the test to just crash here.
> >     
> >     > QFATAL : archiveModelTest::testGetSelectionRoot(test1) ASSERT failure in QCoreApplication: "there should be only one application object", file /s/kde/src/qt4/src/corelib/kernel/qcoreapplication.cpp, line 753

This should be fixed now. Carried initialization stuff to where they belong.


- Alim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110672/#review65811
-----------------------------------------------------------


On Sept. 6, 2014, 5:54 p.m., Alim Gokkaya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110672/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2014, 5:54 p.m.)
> 
> 
> Review request for KDE Utils, Albert Astals Cid and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch enables extracting multiple files using drag&drop by removing the code that singles the selection.
> 
> 
> Diffs
> -----
> 
>   part/part.cpp b4ebcd2 
>   part/test/CMakeLists.txt PRE-CREATION 
>   part/test/archivemodeltest.cpp PRE-CREATION 
>   part/CMakeLists.txt 9e38443 
>   part/archivemodel.h 7f8c527 
>   part/archivemodel.cpp 4326268 
>   part/archiveview.cpp 6b9918d 
>   part/part.h 5379b9f 
> 
> Diff: https://git.reviewboard.kde.org/r/110672/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alim Gokkaya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140906/3980e8ea/attachment.html>