Review Request 120204: Create password-protected archives with Ark

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120204/#review68795
-----------------------------------------------------------


Thanks for the patch!

I believe it still needs some work: in addition to the issues I mentioned below, `AddDialog` is only used when compressing a file via Dolphin's context menu, so one cannot create a new encrypted file inside Ark itself, for example. This is a blocker for me. It would also be nice of the mimetypes that support password encryption did not need to be hardcoded in `AddDialog`.

There's some work towards implementing this feature in the `basyskom` branch in case you want to take a look. It's crashy and does a lot more than that, though (ie. here be dragons :-)


kerfuffle/adddialog.cpp
<https://git.reviewboard.kde.org/r/120204/#comment48118>

    I think these comments can be removed now.



kerfuffle/adddialog.cpp
<https://git.reviewboard.kde.org/r/120204/#comment48121>

    If the default mimetype is set to something that doesn't allow passwords, it's possible to see those extra options being shown and quickly hidden between this call and the `filterChanged` signal being emitted. You could probably just rely on the latter.



kerfuffle/adddialog.cpp
<https://git.reviewboard.kde.org/r/120204/#comment48117>

    IIRC `Q_UNUSED` already adds a `;` at the end.



kerfuffle/adddialog.cpp
<https://git.reviewboard.kde.org/r/120204/#comment48122>

    These should all be `const`.



kerfuffle/adddialog.ui
<https://git.reviewboard.kde.org/r/120204/#comment48119>

    There's an extra space between "Extra" and "Options" here.



kerfuffle/addtoarchive.cpp
<https://git.reviewboard.kde.org/r/120204/#comment48120>

    I think this is too late to show this message: the user has entered both passwords, the dialog has beenc losed and then this popup says something went wrong and the user has to repeat the whole procedure again.



kerfuffle/addtoarchive.cpp
<https://git.reviewboard.kde.org/r/120204/#comment48116>

    These UI messages should end with a full stop.


- Raphael Kubo da Costa


On Sept. 14, 2014, 8:06 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120204/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2014, 8:06 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 253694
>     http://bugs.kde.org/show_bug.cgi?id=253694
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch allows the users to create password-protected archives using Ark. 
> The supported plugins are `zip`, `7z` and `rar`.
> The input fields for the passwords are displayed only when the relevent mime filters are selected in the `AddDialog` window.
> 
> 
> Diffs
> -----
> 
>   plugins/clirarplugin/cliplugin.cpp f5f7b184cb9f7ee16efd74968f2e86dc83668b4d 
>   kerfuffle/cliinterface.cpp eab1c6a3200543989fd501e4d54e3e0b06b48999 
>   plugins/cli7zplugin/cliplugin.cpp 500f121de97ef395110658a6ca495298bc797b46 
>   kerfuffle/addtoarchive.h fa4608e0c0df9ea9cec3aa9e7323fb53dd1b12d3 
>   kerfuffle/addtoarchive.cpp d13e0958468e3bb1aa85606e4fd4d3cb8ef6d3c0 
>   kerfuffle/adddialog.h 7c9f03e916da3a410482be2b45ff30923dfc1f9f 
>   kerfuffle/adddialog.cpp 2950ee6e22c90c770bb3b9128243f9786989ee52 
>   kerfuffle/adddialog.ui a1c595b89202b1f2b44dc4f9c2faf68f5f655eb1 
>   plugins/clizipplugin/cliplugin.cpp 1be2a10f722865c23fba6df5c25993742ce38d69 
> 
> Diff: https://git.reviewboard.kde.org/r/120204/diff/
> 
> 
> Testing
> -------
> 
> Create `.zip`, `.7z` and `.rar` archives using the Ark `AddDialog` dialog (right click on an entry in Dolphin -> Compress -> Compress to...).
> Those archives are created as expected and their entries are marked as *Password protected*.
> If the user clicks on those entries, the standard password dialog is prompted to the user.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20141021/9c6525d2/attachment.html>