Review Request 120463: [kwalletmanager] MInor fixes in main.cpp

Arjun AK arjunak234 at gmail.com
Thu Oct 9 16:53:26 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120463/
-----------------------------------------------------------

(Updated Oct. 9, 2014, 4:53 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Utils and Valentin Rusu.


Repository: kwalletmanager


Description
-------

1.`wm.openwallet()` should be executed if the argument is not a file
2.Start loop from second argument since the first argument is the name of program
3.Store the arguments into a variable since `QCoreApplication::arguments()` is expensive


Diffs
-----

  src/manager/main.cpp e9d00c4 

Diff: https://git.reviewboard.kde.org/r/120463/diff/


Testing
-------


Thanks,

Arjun AK

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20141009/3c97ad16/attachment.html>


More information about the Kde-utils-devel mailing list