Review Request 120463: [kwalletmanager] MInor fixes in main.cpp

[Valentin Rusu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120463/#review68059
-----------------------------------------------------------

Ship it!


Looks good to me. Wonder why nobody catched this up until today. Perhaps nobody tries to open wallets by name on the CLI?

- Valentin Rusu


On Oct. 2, 2014, 1:56 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120463/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2014, 1:56 p.m.)
> 
> 
> Review request for KDE Utils and Valentin Rusu.
> 
> 
> Repository: kwalletmanager
> 
> 
> Description
> -------
> 
> 1.`wm.openwallet()` should be executed if the argument is not a file
> 2.Start loop from second argument since the first argument is the name of program
> 3.Store the arguments into a variable since `QCoreApplication::arguments()` is expensive
> 
> 
> Diffs
> -----
> 
>   src/manager/main.cpp e9d00c4 
> 
> Diff: https://git.reviewboard.kde.org/r/120463/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20141007/54b19c6d/attachment.html>