Review Request 117178: Fix of Bug 330979

[Evan Teran]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117178/#review54675
-----------------------------------------------------------


@Raushan Kumar, I must (again) reject this patch. It is simply in the wrong place. The correct place to solve this issue is NOT at the display level, but instead at a more fundamental part of the calculator code. If you patch the issue at too high a level, then there is a risk of the same problem being triggered by a different context.

- Evan Teran


On March 30, 2014, 6:01 a.m., Raushan Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117178/
> -----------------------------------------------------------
> 
> (Updated March 30, 2014, 6:01 a.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Bugs: 330979 and Bug
>     http://bugs.kde.org/show_bug.cgi?id=330979
>     http://bugs.kde.org/show_bug.cgi?id=Bug
> 
> 
> Repository: kcalc
> 
> 
> Description
> -------
> 
> while calculating x*(10^y) if value of y>1000000 then kcalc gets hanged sometime ,sometime its crashes for large value of y.And after applying the patch I have attached will fix this by not taking very large input in this case.Today when I was using my friends laptop ,he uses windows and there I found that there also same thing happening.They have also used the same concept ,not to take large input in this case.
> https://bugs.kde.org/show_bug.cgi?id=330979
> 
> 
> Diffs
> -----
> 
>   kcalcdisplay.cpp a675e09 
> 
> Diff: https://git.reviewboard.kde.org/r/117178/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Raushan Kumar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140331/2584420b/attachment.html>