<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117178/">https://git.reviewboard.kde.org/r/117178/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Raushan Kumar, I must (again) reject this patch. It is simply in the wrong place. The correct place to solve this issue is NOT at the display level, but instead at a more fundamental part of the calculator code. If you patch the issue at too high a level, then there is a risk of the same problem being triggered by a different context.</pre>
<br />
<p>- Evan Teran</p>
<br />
<p>On March 30th, 2014, 6:01 a.m. UTC, Raushan Kumar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Raushan Kumar.</div>
<p style="color: grey;"><i>Updated March 30, 2014, 6:01 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=330979">330979</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=Bug">Bug</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcalc
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">while calculating x*(10^y) if value of y>1000000 then kcalc gets hanged sometime ,sometime its crashes for large value of y.And after applying the patch I have attached will fix this by not taking very large input in this case.Today when I was using my friends laptop ,he uses windows and there I found that there also same thing happening.They have also used the same concept ,not to take large input in this case.
https://bugs.kde.org/show_bug.cgi?id=330979</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcalcdisplay.cpp <span style="color: grey">(a675e09)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117178/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>