Review Request 114658: Fixes the data loss caused when user closes kwalletmanager with unsaved changes

[Valentin Rusu]

> On Dec. 25, 2013, 10:15 p.m., Valentin Rusu wrote:
> > Ship It!
> 
> Christoph Feck wrote:
>     What is the status of this patch? Arjun probably has no commit rights.
> 
> Arjun Ak wrote:
>     I can still reproduce this. Hasn't anyone committed this yet?

When a review is marked "ship it", then you're supposed to commit it, then push it to this repository.
Your commit message should have a line reading like this
REVIEW: 114658

If that line is given in the commit message, then this review will get updated and we'll all know it was already pushed. However, you can push without that line. But from your message I understand you didn't. Am I right ?


- Valentin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114658/#review46154
-----------------------------------------------------------


On June 26, 2014, 7:36 a.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114658/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 7:36 a.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Bugs: 329165
>     http://bugs.kde.org/show_bug.cgi?id=329165
> 
> 
> Repository: kwalletmanager
> 
> 
> Description
> -------
> 
> Patch to fix Bug 329165(Closing the app leads to loss of unsaved data)
> 
> 
> Diffs
> -----
> 
>   src/manager/kwalleteditor.h f3d08f3 
>   src/manager/kwalleteditor.cpp c2c5cd7 
>   src/manager/kwalletmanager.h 7489077 
>   src/manager/kwalletmanager.cpp a85c753 
>   src/manager/kwalletmanagerwidget.h df1e4fa 
>   src/manager/kwalletmanagerwidget.cpp c855c91 
>   src/manager/kwalletmanagerwidgetitem.h ad2451e 
>   src/manager/kwalletmanagerwidgetitem.cpp 79bb476 
>   src/manager/walletcontrolwidget.h fb94999 
>   src/manager/walletcontrolwidget.cpp a88cf67 
> 
> Diff: https://git.reviewboard.kde.org/r/114658/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140627/6010166a/attachment.html>