<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114658/">https://git.reviewboard.kde.org/r/114658/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 25th, 2013, 10:15 p.m. UTC, <b>Valentin Rusu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
<p>On February 9th, 2014, 3:34 p.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What is the status of this patch? Arjun probably has no commit rights.</pre>
</blockquote>
<p>On June 22nd, 2014, 7:38 a.m. UTC, <b>Arjun Ak</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can still reproduce this. Hasn't anyone committed this yet?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When a review is marked "ship it", then you're supposed to commit it, then push it to this repository.
Your commit message should have a line reading like this
REVIEW: 114658
If that line is given in the commit message, then this review will get updated and we'll all know it was already pushed. However, you can push without that line. But from your message I understand you didn't. Am I right ?
</pre>
<br />
<p>- Valentin</p>
<br />
<p>On June 26th, 2014, 7:36 a.m. UTC, Arjun Ak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Arjun Ak.</div>
<p style="color: grey;"><i>Updated June 26, 2014, 7:36 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=329165">329165</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwalletmanager
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch to fix Bug 329165(Closing the app leads to loss of unsaved data)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/manager/kwalleteditor.h <span style="color: grey">(f3d08f3)</span></li>
<li>src/manager/kwalleteditor.cpp <span style="color: grey">(c2c5cd7)</span></li>
<li>src/manager/kwalletmanager.h <span style="color: grey">(7489077)</span></li>
<li>src/manager/kwalletmanager.cpp <span style="color: grey">(a85c753)</span></li>
<li>src/manager/kwalletmanagerwidget.h <span style="color: grey">(df1e4fa)</span></li>
<li>src/manager/kwalletmanagerwidget.cpp <span style="color: grey">(c855c91)</span></li>
<li>src/manager/kwalletmanagerwidgetitem.h <span style="color: grey">(ad2451e)</span></li>
<li>src/manager/kwalletmanagerwidgetitem.cpp <span style="color: grey">(79bb476)</span></li>
<li>src/manager/walletcontrolwidget.h <span style="color: grey">(fb94999)</span></li>
<li>src/manager/walletcontrolwidget.cpp <span style="color: grey">(a88cf67)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114658/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>