Review Request 120204: Create password-protected archives with Ark

[Elvis Angelaccio]

> On Ott. 21, 2014, 11:17 a.m., Raphael Kubo da Costa wrote:
> > kerfuffle/adddialog.cpp, lines 148-152
> > <https://git.reviewboard.kde.org/r/120204/diff/1/?file=312245#file312245line148>
> >
> >     These should all be `const`.

Those strings are no more hardcoded in `AddDialog`.


> On Ott. 21, 2014, 11:17 a.m., Raphael Kubo da Costa wrote:
> > kerfuffle/addtoarchive.cpp, line 188
> > <https://git.reviewboard.kde.org/r/120204/diff/1/?file=312248#file312248line188>
> >
> >     I think this is too late to show this message: the user has entered both passwords, the dialog has beenc losed and then this popup says something went wrong and the user has to repeat the whole procedure again.

Now the passwords check is done earlier, in the dialog itself.


> On Ott. 21, 2014, 11:17 a.m., Raphael Kubo da Costa wrote:
> > kerfuffle/addtoarchive.cpp, line 189
> > <https://git.reviewboard.kde.org/r/120204/diff/1/?file=312248#file312248line189>
> >
> >     These UI messages should end with a full stop.

I've added a period to the sentence. Is that what you meant?


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120204/#review68795
-----------------------------------------------------------


On Dic. 21, 2014, 10:50 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120204/
> -----------------------------------------------------------
> 
> (Updated Dic. 21, 2014, 10:50 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 253694
>     http://bugs.kde.org/show_bug.cgi?id=253694
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch allows the users to create password-protected archives using Ark. 
> The supported plugins are `zip`, `7z` and `rar`.
> The input fields for the passwords are displayed only when the relevent mime filters are selected in the `AddDialog` window.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/CMakeLists.txt 8c56b4f46090c924f0848ad229b6a3779af1f1f3 
>   app/mainwindow.cpp aee823174a0b731e125381be09181938cdb6dd7d 
>   kerfuffle/adddialog.h 7c9f03e916da3a410482be2b45ff30923dfc1f9f 
>   kerfuffle/adddialog.cpp 2950ee6e22c90c770bb3b9128243f9786989ee52 
>   kerfuffle/adddialog.ui a1c595b89202b1f2b44dc4f9c2faf68f5f655eb1 
>   kerfuffle/addtoarchive.h fa4608e0c0df9ea9cec3aa9e7323fb53dd1b12d3 
>   kerfuffle/addtoarchive.cpp d13e0958468e3bb1aa85606e4fd4d3cb8ef6d3c0 
>   kerfuffle/archive.h 515788f978c1d29146c25dcb57a9dad2d46371f7 
>   kerfuffle/archive.cpp c2c5b18528def63405a8703475b1c592ca945973 
>   kerfuffle/archiveinterface.h 801318b7842d78a0de54700ffdb43a945f513fbf 
>   kerfuffle/archiveinterface.cpp 3319de074225ccf8cb0fe54ffadca5882cf29342 
>   kerfuffle/cliinterface.h b4d79ed2f3ffbbbe28f7087f1fbff36de5138f36 
>   kerfuffle/cliinterface.cpp eab1c6a3200543989fd501e4d54e3e0b06b48999 
>   kerfuffle/createdialog.h PRE-CREATION 
>   kerfuffle/createdialog.cpp PRE-CREATION 
>   kerfuffle/createdialog.ui PRE-CREATION 
>   kerfuffle/kerfufflePlugin.desktop 3999d24f414ede1bb377f47b8c7d46dc44459b7d 
>   part/archivemodel.h 7f8c527fc331778e0ec74dce047eba5c56507499 
>   part/archivemodel.cpp 43262689ad989e3a9233e279db6dcd532084a031 
>   part/part.cpp 09fe1cbfcc7f4345fe12932055dcb041f50abb7b 
>   plugins/cli7zplugin/cliplugin.cpp 500f121de97ef395110658a6ca495298bc797b46 
>   plugins/cli7zplugin/kerfuffle_cli7z.desktop.cmake 29b355af72b02d767e099a6e7a61778a70ae4476 
>   plugins/clirarplugin/cliplugin.cpp f5f7b184cb9f7ee16efd74968f2e86dc83668b4d 
>   plugins/clirarplugin/kerfuffle_clirar.desktop.cmake 3091d9d384952fbe27a43049c66c2ee998017957 
>   plugins/clizipplugin/cliplugin.cpp 1be2a10f722865c23fba6df5c25993742ce38d69 
>   plugins/clizipplugin/kerfuffle_clizip.desktop.cmake 32ceced7b913c4d4a0d2007b4b3ea7b4ec850e35 
> 
> Diff: https://git.reviewboard.kde.org/r/120204/diff/
> 
> 
> Testing
> -------
> 
> Create `.zip`, `.7z` and `.rar` archives using the Ark `AddDialog` dialog (right click on an entry in Dolphin -> Compress -> Compress to...).
> Those archives are created as expected and their entries are marked as *Password protected*.
> If the user clicks on those entries, the standard password dialog is prompted to the user.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20141221/92660880/attachment-0001.html>