Review Request 119893: Ensure destination is writable before extraction

[Arjun AK]

> On Dec. 12, 2014, 4:43 a.m., Raphael Kubo da Costa wrote:
> > Quick comments while on holiday: please sort your includes, and I would expect this kind of check to be in a place that would work for both drag'n'drop and regular extractions.

>please sort your includes

Ok

>and I would expect this kind of check to be in a place that would work for both drag'n'drop and regular extractions.

The other check is inside extractiondialog.cpp, when KIO::NetAccess::mkdir() fails. Can these both be combined?


- Arjun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119893/#review71838
-----------------------------------------------------------


On Dec. 11, 2014, 1:23 a.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119893/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 1:23 a.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> 1. Open dolphin, drag and drop an archive file onto a read-only directory in the  places panel
> 2. All the files get extracted to the home directory
> 
> 
> Diffs
> -----
> 
>   app/extractHereDndPlugin.cpp 685a6b7 
> 
> Diff: https://git.reviewboard.kde.org/r/119893/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20141212/d0ed6376/attachment.html>