Review Request 119893: Ensure destination is writable before extraction

Raphael Kubo da Costa rakuco at FreeBSD.org
Thu Dec 11 23:13:23 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119893/#review71838
-----------------------------------------------------------


Quick comments while on holiday: please sort your includes, and I would expect this kind of check to be in a place that would work for both drag'n'drop and regular extractions.

- Raphael Kubo da Costa


On Dec. 10, 2014, 9:53 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119893/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 9:53 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> 1. Open dolphin, drag and drop an archive file onto a read-only directory in the  places panel
> 2. All the files get extracted to the home directory
> 
> 
> Diffs
> -----
> 
>   app/extractHereDndPlugin.cpp 685a6b7 
> 
> Diff: https://git.reviewboard.kde.org/r/119893/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20141211/4d2cc09d/attachment.html>


More information about the Kde-utils-devel mailing list