Review Request 111310: kcalc: Use pow(10, x) instead of exp10(x).

Evan Teran evan.teran at gmail.com
Sat Jun 29 15:58:18 UTC 2013


Hey Raphael,

Thanks for the quick and easy patch :-). I'm a little unfamiliar with the
review board workflow, so I have a question. Should i just click "Ship
It!"? Or am I also supposed to download and apply the patch myself?

I'm happy to do either, as this trivial patch looks good to me.

Thanks,
Evan


On Sat, Jun 29, 2013 at 11:51 AM, Raphael Kubo da Costa
<rakuco at freebsd.org>wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111310/
>   Review request for KDE Utils and Evan Teran.
> By Raphael Kubo da Costa.
> Description
>
> exp10() is a glibc extension and thus not portable that can be replaced by pow(10, x), which is part of C99.
>
>   Testing
>
> kcalc builds on non-Linux systems without mpfr.
>
>   Diffs
>
>    - knumber/knumber_float.cpp (5af51639c14189c6406edcfa27910cf669fc0d74)
>
> View Diff <http://git.reviewboard.kde.org/r/111310/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130629/38a7759c/attachment.html>


More information about the Kde-utils-devel mailing list