Review Request 111310: kcalc: Use pow(10, x) instead of exp10(x).

Evan Teran evan.teran at gmail.com
Sat Jun 29 16:14:37 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111310/#review35286
-----------------------------------------------------------

Ship it!


Ship It!

- Evan Teran


On June 29, 2013, 3:51 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111310/
> -----------------------------------------------------------
> 
> (Updated June 29, 2013, 3:51 p.m.)
> 
> 
> Review request for KDE Utils and Evan Teran.
> 
> 
> Description
> -------
> 
> exp10() is a glibc extension and thus not portable that can be replaced by pow(10, x), which is part of C99.
> 
> 
> Diffs
> -----
> 
>   knumber/knumber_float.cpp 5af51639c14189c6406edcfa27910cf669fc0d74 
> 
> Diff: http://git.reviewboard.kde.org/r/111310/diff/
> 
> 
> Testing
> -------
> 
> kcalc builds on non-Linux systems without mpfr.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130629/59dd7cf1/attachment.html>


More information about the Kde-utils-devel mailing list