Review Request 106352: Display the status of the cleaning in a widget

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106352/#review35341
-----------------------------------------------------------


My two cents without any HIG backing or maintainer hat: wouldn't it be better to add a small progress bar at the bottom of the main window itself? I thought pop up dialogs were generally frowned upon.

- Raphael Kubo da Costa


On Sept. 6, 2012, 2:02 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106352/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2012, 2:02 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> Add a QWidget with a QProgressBar and a QPlainTextEdit to display the
> progress of the cleanup. Also add a button to stop the cleaning.
> 
> 
> This addresses bug 258585.
>     http://bugs.kde.org/show_bug.cgi?id=258585
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b4f7577 
>   progressbar.ui PRE-CREATION 
>   sweeper.h 6e3a664 
>   sweeper.cpp 559e01d 
>   sweeperdialog.ui fca6a4a 
> 
> Diff: http://git.reviewboard.kde.org/r/106352/diff/
> 
> 
> Testing
> -------
> 
> Cleaned everything, the progressbar works, I can stop the cleaning.
> The OK button closes only this dialog, not the main window.
> 
> 
> Screenshots
> -----------
> 
> Cleaning widget
>   http://git.reviewboard.kde.org/r/106352/s/717/
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130701/0b3fc4cb/attachment.html>