<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106352/">http://git.reviewboard.kde.org/r/106352/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My two cents without any HIG backing or maintainer hat: wouldn't it be better to add a small progress bar at the bottom of the main window itself? I thought pop up dialogs were generally frowned upon.</pre>
<br />
<p>- Raphael</p>
<br />
<p>On September 6th, 2012, 2:02 p.m. EEST, Andrea Scarpino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated Sept. 6, 2012, 2:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a QWidget with a QProgressBar and a QPlainTextEdit to display the
progress of the cleanup. Also add a button to stop the cleaning.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cleaned everything, the progressbar works, I can stop the cleaning.
The OK button closes only this dialog, not the main window.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=258585">258585</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(b4f7577)</span></li>
<li>progressbar.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>sweeper.h <span style="color: grey">(6e3a664)</span></li>
<li>sweeper.cpp <span style="color: grey">(559e01d)</span></li>
<li>sweeperdialog.ui <span style="color: grey">(fca6a4a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106352/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106352/s/717/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/06/progressbar_400x100.png" style="border: 1px black solid;" alt="Cleaning widget" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>