Review Request: Only require that archive name starts with subfolder name, not that they are identical

[Sandro Mani]

> On Jan. 6, 2013, 1:23 a.m., Kevin Kofler wrote:
> > app/batchextract.cpp, line 71
> > <http://git.reviewboard.kde.org/r/107634/diff/2/?file=104858#file104858line71>
> >
> >     I'm not convinced this simplistic check is an improvement. I've seen many tarballs where the tarball is called something like z88dk-1.10.1.tgz or even z88dk-src-1.10.tgz, but the single folder inside it is called just z88dk, and I don't think extracting to e.g. z88dk-src-1.10/z88dk is an improvement over just extracting to z88dk. (This is just one example, in which prefix matching would work, but I have seen all sorts of other trivial mismatches.)
> >     
> >     In fact, I have doubts about the basic assumption of your patch, i.e. whether comparing the names will really do what the user wants more often than not doing that.

I agree, I've changed the test to handle such cases.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107634/#review24779
-----------------------------------------------------------


On Jan. 6, 2013, 2:02 p.m., Sandro Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107634/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 2:02 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> Only require that archive name starts with subfolder name, not that they are identical
> 
> 
> Improve subfolder autodetection
> 
> 
> Diffs
> -----
> 
>   app/batchextract.cpp 9e466350568384247e99362745205c417b27873f 
>   kerfuffle/archive.h 515788f978c1d29146c25dcb57a9dad2d46371f7 
>   kerfuffle/archive.cpp c2c5b18528def63405a8703475b1c592ca945973 
>   kerfuffle/jobs.cpp aedc62c4c9902c4f3207c648747f2e427446d5e5 
> 
> Diff: http://git.reviewboard.kde.org/r/107634/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Mani
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130106/cced564f/attachment-0001.html>