<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107634/">http://git.reviewboard.kde.org/r/107634/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 6th, 2013, 1:23 a.m., <b>Kevin Kofler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107634/diff/2/?file=104858#file104858line71" style="color: black; font-weight: bold; text-decoration: underline;">app/batchextract.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">BatchExtract::~BatchExtract()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">71</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">((</span><span class="n">autoSubfolder</span><span class="p">())</span> <span class="o">&&</span> <span class="p">(</span><span class="o">!</span><span class="n">archive</span><span class="o">-></span><span class="n">isSingleFolderArchive</span><span class="p">()))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">71</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">((</span><span class="n">autoSubfolder</span><span class="p">())</span> <span class="o">&&</span> <span class="p">(</span><span class="o">!</span><span class="n">archive</span><span class="o">-></span><span class="n">isSingleFolderArchive</span><span class="p">()</span><span class="hl"> </span><span class="o"><span class="hl">||</span></span><span class="hl"> </span><span class="n"><span class="hl">archive</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">subfolderName</span></span><span class="p"><span class="hl">()</span></span><span class="hl"> </span><span class="o"><span class="hl">!=</span></span><span class="hl"> </span><span class="n"><span class="hl">archive</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">fileBaseName</span></span><span class="p"><span class="hl">()</span>))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not convinced this simplistic check is an improvement. I've seen many tarballs where the tarball is called something like z88dk-1.10.1.tgz or even z88dk-src-1.10.tgz, but the single folder inside it is called just z88dk, and I don't think extracting to e.g. z88dk-src-1.10/z88dk is an improvement over just extracting to z88dk. (This is just one example, in which prefix matching would work, but I have seen all sorts of other trivial mismatches.)
In fact, I have doubts about the basic assumption of your patch, i.e. whether comparing the names will really do what the user wants more often than not doing that.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree, I've changed the test to handle such cases.</pre>
<br />
<p>- Sandro</p>
<br />
<p>On January 6th, 2013, 2:02 p.m., Sandro Mani wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Sandro Mani.</div>
<p style="color: grey;"><i>Updated Jan. 6, 2013, 2:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only require that archive name starts with subfolder name, not that they are identical
Improve subfolder autodetection</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/batchextract.cpp <span style="color: grey">(9e466350568384247e99362745205c417b27873f)</span></li>
<li>kerfuffle/archive.h <span style="color: grey">(515788f978c1d29146c25dcb57a9dad2d46371f7)</span></li>
<li>kerfuffle/archive.cpp <span style="color: grey">(c2c5b18528def63405a8703475b1c592ca945973)</span></li>
<li>kerfuffle/jobs.cpp <span style="color: grey">(aedc62c4c9902c4f3207c648747f2e427446d5e5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107634/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>