Review Request 109847: Sort email addresses in main list by TLD first, then domain, and only last by account name

[Rolf Eike Beer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109847/#review30515
-----------------------------------------------------------


Looks good, but I have 2 things. First, this should be configurable, so please also add an option somewhere in the Appearance section to make that configurable. I'm not sure if this should be only 2 options, i.e. old behavior and your one, or if we may need more options here. The other 2 valid options I could think of would be "sort by second level domain first" and "sort by whole domain". I'm not sure about those 2.

- Rolf Eike Beer


On April 3, 2013, 8:06 p.m., Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109847/
> -----------------------------------------------------------
> 
> (Updated April 3, 2013, 8:06 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> Sort email addresses in main list by TLD first, then domain, and only last by account name.
> (1) email address is split along @ and .
> (2a) list is reversed
> (2b) list elements are joined, two elements separated by .
> 
> 
> This addresses bug 278376.
>     http://bugs.kde.org/show_bug.cgi?id=278376
> 
> 
> Diffs
> -----
> 
>   model/keylistproxymodel.cpp e91cb08 
> 
> Diff: http://git.reviewboard.kde.org/r/109847/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Fischer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130405/8c665a7b/attachment.html>