<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109847/">http://git.reviewboard.kde.org/r/109847/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, but I have 2 things. First, this should be configurable, so please also add an option somewhere in the Appearance section to make that configurable. I'm not sure if this should be only 2 options, i.e. old behavior and your one, or if we may need more options here. The other 2 valid options I could think of would be "sort by second level domain first" and "sort by whole domain". I'm not sure about those 2.</pre>
<br />
<p>- Rolf Eike</p>
<br />
<p>On April 3rd, 2013, 8:06 p.m. UTC, Thomas Fischer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Thomas Fischer.</div>
<p style="color: grey;"><i>Updated April 3, 2013, 8:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sort email addresses in main list by TLD first, then domain, and only last by account name.
(1) email address is split along @ and .
(2a) list is reversed
(2b) list elements are joined, two elements separated by .</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=278376">278376</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>model/keylistproxymodel.cpp <span style="color: grey">(e91cb08)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109847/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>