Review Request: Add and use alternative commant line program name

[Raphael Kubo da Costa]

> On May 10, 2012, 3:41 a.m., Raphael Kubo da Costa wrote:
> > Thanks for the patch. Please commit it to master.

Thanks you for committing.

For future reference: I saw that you committed this patch (50d645ad0a2ffa53e5d032aac52b3874e816ae67) and the one for review request 103306 (4ede2c074e5f622edf8333892286296f2d4e9b8b) without rebasing, which ended up creating 3 useless merge commits in master. And you also did not use the REVIEW keyword in the commit message to reference the review requests you made. This all makes going through Ark's history harder.

For your next patches, please check <http://techbase.kde.org/Policies/SVN_Commit_Policy#Special_keywords_in_SVN_log_messages> for how to use the REVIEW keyword in your commit messages and rebase your commits correctly on top of the current branch so these unnecessary merge commits are not created.

You now need to close your review requests manually.


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103223/#review13636
-----------------------------------------------------------


On May 9, 2012, 1:35 p.m., Michal Sciubidlo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103223/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 1:35 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> Add and use alternative commant line program name.
> ListProgramAlternative, ExtractProgramAlternative, DeleteProgramAlternative, AddProgramAlternative can be set by CliInterface plugins if CliInterface can't find normal names it can use alternative ones. This patch is useful for 7z and 7za programs. Ark used 7z program but it's not allways installed. 7za can operate on 7z archives and is more common.
> 
> 
> This addresses bug 208864.
>     http://bugs.kde.org/show_bug.cgi?id=208864
> 
> 
> Diffs
> -----
> 
>   kerfuffle/cliinterface.h 3d8f99e 
>   kerfuffle/cliinterface.cpp d1d3b1f 
>   plugins/cli7zplugin/cliplugin.cpp 246f42c 
>   plugins/clilhaplugin/cliplugin.cpp ab2d315 
>   plugins/clirarplugin/cliplugin.cpp 0d2c596 
>   plugins/clizipplugin/cliplugin.cpp b79fea2 
> 
> Diff: http://git.reviewboard.kde.org/r/103223/diff/
> 
> 
> Testing
> -------
> 
> Delete /usr/bin/7z file keep /usr/bin/7za. Ark still can work with 7z archives.
> 
> 
> Thanks,
> 
> Michal Sciubidlo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120510/4b101639/attachment.html>