<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103223/">http://git.reviewboard.kde.org/r/103223/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 10th, 2012, 3:41 a.m., <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch. Please commit it to master.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks you for committing.
For future reference: I saw that you committed this patch (50d645ad0a2ffa53e5d032aac52b3874e816ae67) and the one for review request 103306 (4ede2c074e5f622edf8333892286296f2d4e9b8b) without rebasing, which ended up creating 3 useless merge commits in master. And you also did not use the REVIEW keyword in the commit message to reference the review requests you made. This all makes going through Ark's history harder.
For your next patches, please check <http://techbase.kde.org/Policies/SVN_Commit_Policy#Special_keywords_in_SVN_log_messages> for how to use the REVIEW keyword in your commit messages and rebase your commits correctly on top of the current branch so these unnecessary merge commits are not created.
You now need to close your review requests manually.</pre>
<br />
<p>- Raphael</p>
<br />
<p>On May 9th, 2012, 1:35 p.m., Michal Sciubidlo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Michal Sciubidlo.</div>
<p style="color: grey;"><i>Updated May 9, 2012, 1:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add and use alternative commant line program name.
ListProgramAlternative, ExtractProgramAlternative, DeleteProgramAlternative, AddProgramAlternative can be set by CliInterface plugins if CliInterface can't find normal names it can use alternative ones. This patch is useful for 7z and 7za programs. Ark used 7z program but it's not allways installed. 7za can operate on 7z archives and is more common.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Delete /usr/bin/7z file keep /usr/bin/7za. Ark still can work with 7z archives.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=208864">208864</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kerfuffle/cliinterface.h <span style="color: grey">(3d8f99e)</span></li>
<li>kerfuffle/cliinterface.cpp <span style="color: grey">(d1d3b1f)</span></li>
<li>plugins/cli7zplugin/cliplugin.cpp <span style="color: grey">(246f42c)</span></li>
<li>plugins/clilhaplugin/cliplugin.cpp <span style="color: grey">(ab2d315)</span></li>
<li>plugins/clirarplugin/cliplugin.cpp <span style="color: grey">(0d2c596)</span></li>
<li>plugins/clizipplugin/cliplugin.cpp <span style="color: grey">(b79fea2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103223/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>