Review Request: Encapsulate ArchiveDirNode::m_entries

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104636/#review13486
-----------------------------------------------------------

Ship it!


Thanks a lot for the patch. Do you already have a commit account or shall I commit it for you? If you do have a commit account, please commit to the KDE/4.8 branch and use `git merge --log --edit -s recursive -Xours' in the master branch to merge the change.

- Raphael Kubo da Costa


On May 5, 2012, 4:55 p.m., Nathan Mills wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104636/
> -----------------------------------------------------------
> 
> (Updated May 5, 2012, 4:55 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> This patch improves the encapsulation of ArchiveDirNode::m_entries. Now, the reference returned by entries() cannot be used for assignment. I added three other methods to set, append, and delete entries.
> 
> 
> Diffs
> -----
> 
>   part/archivemodel.cpp 8389d59 
> 
> Diff: http://git.reviewboard.kde.org/r/104636/diff/
> 
> 
> Testing
> -------
> 
> I compiled Ark with this patch.
> 
> 
> Thanks,
> 
> Nathan Mills
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120505/4e306fe4/attachment.html>