Review Request: Encapsulate ArchiveDirNode::m_entries
Nathan Mills
nn.dm55 at gmail.com
Sat May 5 16:55:40 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104636/
-----------------------------------------------------------
(Updated May 5, 2012, 4:55 p.m.)
Review request for KDE Utils and Raphael Kubo da Costa.
Changes
-------
Added 'kdeutils' group, updated patch, and clicked the Fixed button on all issues.
Description
-------
This patch improves the encapsulation of ArchiveDirNode::m_entries. Now, the reference returned by entries() cannot be used for assignment. I added three other methods to set, append, and delete entries.
Diffs (updated)
-----
part/archivemodel.cpp 8389d59
Diff: http://git.reviewboard.kde.org/r/104636/diff/
Testing
-------
I compiled Ark with this patch.
Thanks,
Nathan Mills
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120505/55f23aa9/attachment.html>
More information about the Kde-utils-devel
mailing list