Review Request: lha archive support

Theofilos Intzoglou int.teo at gmail.com
Sun Sep 25 22:00:42 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102682/
-----------------------------------------------------------

(Updated Sept. 25, 2011, 10 p.m.)


Review request for KDE Utils and Raphael Kubo da Costa.


Changes
-------

I fixed all the problems that you mentioned. There is only one thing that I noticed in some old lha files: The directories don't appear as a separate entry in the archive and as a result in the treeview these directories appear with the "file" icon instead of the blue folder.

For example:
$ lha v -v ~/Downloads/8to16.lha 
PERMISSION  UID  GID    PACKED    SIZE  RATIO METHOD CRC     STAMP            LV
---------- ----------- ------- ------- ------ ---------- ------------------- ---
8to16_v1.3.info
[generic]                  427     804  53.1% -lh5- 463b 1992-09-02 13:18:46 [0]
8to16_v1.3/8to16
[generic]                 1672    3204  52.2% -lh5- 20fc 1992-09-02 13:28:30 [0]
...


Description
-------

Add support for lha archives.


This addresses bug 231896.
    http://bugs.kde.org/show_bug.cgi?id=231896


Diffs (updated)
-----

  app/ark.desktop 2c4e348 
  app/ark_dndextract.desktop 9dd2a59 
  app/ark_servicemenu.desktop 0341c7e 
  plugins/CMakeLists.txt e3cb9ec 
  plugins/clilhaplugin/CMakeLists.txt PRE-CREATION 
  plugins/clilhaplugin/cliplugin.h PRE-CREATION 
  plugins/clilhaplugin/cliplugin.cpp PRE-CREATION 
  plugins/clilhaplugin/kerfuffle_clilha.desktop PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/102682/diff/diff


Testing
-------

Tested opening and modifying lha archives created using the lha utility from http://lha.sourceforge.jp/ and some archives from http://aminet.net


Thanks,

Theofilos Intzoglou

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20110925/d77a7a45/attachment.html>


More information about the Kde-utils-devel mailing list