Review Request: lha archive support

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102682/#review6811
-----------------------------------------------------------


Please remove the trailing whitespaces too.


app/ark_addtoservicemenu.desktop
<http://git.reviewboard.kde.org/r/102682/#comment6068>

    Hmm, I don't think this is needed -- it's better to keep the list as short as possible, and lha isn't very popular.



plugins/clilhaplugin/cliplugin.cpp
<http://git.reviewboard.kde.org/r/102682/#comment6069>

    This header is not needed.



plugins/clilhaplugin/cliplugin.cpp
<http://git.reviewboard.kde.org/r/102682/#comment6070>

    Not needed.



plugins/clilhaplugin/cliplugin.cpp
<http://git.reviewboard.kde.org/r/102682/#comment6072>

    const



plugins/clilhaplugin/cliplugin.cpp
<http://git.reviewboard.kde.org/r/102682/#comment6073>

    What if you set it to Header and get rid of the EndOfEntries state?



plugins/clilhaplugin/cliplugin.cpp
<http://git.reviewboard.kde.org/r/102682/#comment6074>

    line is already a QString.



plugins/clilhaplugin/cliplugin.cpp
<http://git.reviewboard.kde.org/r/102682/#comment6075>

    I find it cleaner if you just check if the entry ends with '/'; we can just adjust that later if a weird archive is found.


- Raphael Kubo da Costa


On Sept. 25, 2011, 8:40 p.m., Theofilos Intzoglou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102682/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2011, 8:40 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> Add support for lha archives.
> 
> 
> This addresses bug 231896.
>     http://bugs.kde.org/show_bug.cgi?id=231896
> 
> 
> Diffs
> -----
> 
>   app/ark.desktop 2c4e348 
>   app/ark_addtoservicemenu.desktop c767031 
>   app/ark_dndextract.desktop 9dd2a59 
>   app/ark_servicemenu.desktop 0341c7e 
>   plugins/CMakeLists.txt e3cb9ec 
>   plugins/clilhaplugin/CMakeLists.txt PRE-CREATION 
>   plugins/clilhaplugin/cliplugin.h PRE-CREATION 
>   plugins/clilhaplugin/cliplugin.cpp PRE-CREATION 
>   plugins/clilhaplugin/kerfuffle_clilha.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102682/diff/diff
> 
> 
> Testing
> -------
> 
> Tested opening and modifying lha archives created using the lha utility from http://lha.sourceforge.jp/ and some archives from http://aminet.net
> 
> 
> Thanks,
> 
> Theofilos Intzoglou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20110925/05a115db/attachment-0001.html>