Review Request: lha archive support

[Theofilos Intzoglou]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102682/#review6810
-----------------------------------------------------------



plugins/clilhaplugin/cliplugin.cpp
<http://git.reviewboard.kde.org/r/102682/#comment6064>

    The only line that contains 8 substrings is the line at the end of the listing. It could be replaced with (line == "---------- ----------- ------- ------- ------ ---------- ------------------- ---"). The first substring has the same width as with the permissions of a file so I avoid just checking for "----------".



plugins/clilhaplugin/cliplugin.cpp
<http://git.reviewboard.kde.org/r/102682/#comment6066>

    The only line that has 8 substrings is the one that appears just after the listing of all files in the archive. Another way to check for that line would be (line == "---------- ----------- ------- ------- ------ ---------- ------------------- ---") or (line.startsWith("----------")) although I want to avoid the second one in case there is a filename starting with so many '-' chars.



plugins/clilhaplugin/cliplugin.cpp
<http://git.reviewboard.kde.org/r/102682/#comment6067>

    I didn't know it could take the value [unknown] :-/ All lha documentation is in japanese which I unfortunately can't read. I searched through the sources of lha and found quite a big list of [*] labels so I will just check if the permissions start with a [.



plugins/clilhaplugin/cliplugin.cpp
<http://git.reviewboard.kde.org/r/102682/#comment6065>

    When I opened an lha archive and added/removed a file or folder the listing wouldn't be updated because the m_status was stuck to EndOfEntries. To make it return to the Entry state I put that check there.


- Theofilos Intzoglou


On Sept. 25, 2011, 6:21 p.m., Theofilos Intzoglou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102682/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2011, 6:21 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> Add support for lha archives.
> 
> 
> This addresses bug 231896.
>     http://bugs.kde.org/show_bug.cgi?id=231896
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt e3cb9ec 
>   plugins/clilhaplugin/CMakeLists.txt PRE-CREATION 
>   plugins/clilhaplugin/cliplugin.h PRE-CREATION 
>   plugins/clilhaplugin/cliplugin.cpp PRE-CREATION 
>   plugins/clilhaplugin/kerfuffle_clilha.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102682/diff/diff
> 
> 
> Testing
> -------
> 
> Tested opening and modifying lha archives created using the lha utility from http://lha.sourceforge.jp/ and some archives from http://aminet.net
> 
> 
> Thanks,
> 
> Theofilos Intzoglou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20110925/c78410ab/attachment.html>