Review Request: lha archive support

[Raphael Kubo da Costa]

> On Sept. 25, 2011, 5:59 p.m., Raphael Kubo da Costa wrote:
> > Thanks for the patch. Besides the comments below, please remove the trailing whitespaces, use QLatin1Strings for the strings and QLatin1Char for chars, and use foo(bar) instead of foo( bar ).

Oh, and most of the kDebug() calls you have there can be removed.


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102682/#review6804
-----------------------------------------------------------


On Sept. 25, 2011, 6:21 p.m., Theofilos Intzoglou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102682/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2011, 6:21 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> Add support for lha archives.
> 
> 
> This addresses bug 231896.
>     http://bugs.kde.org/show_bug.cgi?id=231896
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt e3cb9ec 
>   plugins/clilhaplugin/CMakeLists.txt PRE-CREATION 
>   plugins/clilhaplugin/cliplugin.h PRE-CREATION 
>   plugins/clilhaplugin/cliplugin.cpp PRE-CREATION 
>   plugins/clilhaplugin/kerfuffle_clilha.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102682/diff/diff
> 
> 
> Testing
> -------
> 
> Tested opening and modifying lha archives created using the lha utility from http://lha.sourceforge.jp/ and some archives from http://aminet.net
> 
> 
> Thanks,
> 
> Theofilos Intzoglou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20110925/cfffcb1e/attachment.html>