Review Request: Restore the ability to use Ark as an embedded KPart

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102803/
-----------------------------------------------------------

(Updated Oct. 23, 2011, 7:41 p.m.)


Review request for KDE Utils and Raphael Kubo da Costa.


Changes
-------

Ok, big edit.  Each plugin now sets its list of accepted MIME types in the CMakeLists.txt file, either fixed or in accordance with the configuration options, and that is edited into the plugin's desktop file(s).  The cumulative list from all of the plugins is passed up to the top level as SUPPORTED_ARK_MIMETYPES, and that list is edited into the app's and part's desktop files.

All desktop files therefore get the same (consistent) list, and any change in the list of types supported by a plugin is automatically propagated.

Apologies for the huge diff, but it seems that reviewboard doesn't support Git renames.


Description
-------

(Copied from original review request https://svn.reviewboard.kde.org/r/5405/)

In KDE3 it was possible to use Ark as am embedded KPart, e.g. to browse the contents of a remote archive inside Konqueror.  Now in KDE4 this is not possible, ark_part.desktop is installed but contains no MimeTypes list.

This change restores the MIME type list (copied verbatim from the Ark application's desktop file).


Diffs (updated)
-----

  CMakeLists.txt fa623dd 
  app/CMakeLists.txt 71b7cdd 
  app/ark.desktop 8c79d6c 
  app/ark.desktop.cmake PRE-CREATION 
  app/ark_dndextract.desktop 8704137 
  app/ark_dndextract.desktop.cmake PRE-CREATION 
  app/ark_servicemenu.desktop 88e3b57 
  app/ark_servicemenu.desktop.cmake PRE-CREATION 
  part/CMakeLists.txt 0fdbcd1 
  part/ark_part.desktop 123119f 
  part/ark_part.desktop.cmake PRE-CREATION 
  plugins/CMakeLists.txt b1c3c03 
  plugins/cli7zplugin/CMakeLists.txt 3c114be 
  plugins/cli7zplugin/kerfuffle_cli7z.desktop 2c3db3a 
  plugins/cli7zplugin/kerfuffle_cli7z.desktop.cmake PRE-CREATION 
  plugins/clilhaplugin/CMakeLists.txt 54cec6b 
  plugins/clilhaplugin/kerfuffle_clilha.desktop 5db71f2 
  plugins/clilhaplugin/kerfuffle_clilha.desktop.cmake PRE-CREATION 
  plugins/clirarplugin/CMakeLists.txt 9fb2a8e 
  plugins/clirarplugin/kerfuffle_clirar.desktop ab6ae21 
  plugins/clirarplugin/kerfuffle_clirar.desktop.cmake PRE-CREATION 
  plugins/clizipplugin/CMakeLists.txt 37e51d4 
  plugins/clizipplugin/kerfuffle_clizip.desktop 472fbb5 
  plugins/clizipplugin/kerfuffle_clizip.desktop.cmake PRE-CREATION 
  plugins/karchiveplugin/CMakeLists.txt 7c6bf40 
  plugins/karchiveplugin/kerfuffle_karchive.desktop 8ee4c65 
  plugins/karchiveplugin/kerfuffle_karchive.desktop.cmake PRE-CREATION 
  plugins/libarchive/CMakeLists.txt d0a03db 
  plugins/libarchive/kerfuffle_libarchive.desktop 38cf3d2 
  plugins/libarchive/kerfuffle_libarchive.desktop.cmake PRE-CREATION 
  plugins/libarchive/kerfuffle_libarchive_readonly.desktop.cmake 793f49f 
  plugins/libsinglefileplugin/CMakeLists.txt f2399f1 

Diff: http://git.reviewboard.kde.org/r/102803/diff/diff


Testing
-------

Built and installed Ark with these changes, it is now possible to preview the contents of an archive within Konqueror.


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111023/8ddd8aed/attachment.html>