<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102803/">http://git.reviewboard.kde.org/r/102803/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Oct. 23, 2011, 7:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, big edit. Each plugin now sets its list of accepted MIME types in the CMakeLists.txt file, either fixed or in accordance with the configuration options, and that is edited into the plugin's desktop file(s). The cumulative list from all of the plugins is passed up to the top level as SUPPORTED_ARK_MIMETYPES, and that list is edited into the app's and part's desktop files.
All desktop files therefore get the same (consistent) list, and any change in the list of types supported by a plugin is automatically propagated.
Apologies for the huge diff, but it seems that reviewboard doesn't support Git renames.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(Copied from original review request https://svn.reviewboard.kde.org/r/5405/)
In KDE3 it was possible to use Ark as am embedded KPart, e.g. to browse the contents of a remote archive inside Konqueror. Now in KDE4 this is not possible, ark_part.desktop is installed but contains no MimeTypes list.
This change restores the MIME type list (copied verbatim from the Ark application's desktop file).
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built and installed Ark with these changes, it is now possible to preview the contents of an archive within Konqueror.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(fa623dd)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(71b7cdd)</span></li>
<li>app/ark.desktop <span style="color: grey">(8c79d6c)</span></li>
<li>app/ark.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/ark_dndextract.desktop <span style="color: grey">(8704137)</span></li>
<li>app/ark_dndextract.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/ark_servicemenu.desktop <span style="color: grey">(88e3b57)</span></li>
<li>app/ark_servicemenu.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>part/CMakeLists.txt <span style="color: grey">(0fdbcd1)</span></li>
<li>part/ark_part.desktop <span style="color: grey">(123119f)</span></li>
<li>part/ark_part.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/CMakeLists.txt <span style="color: grey">(b1c3c03)</span></li>
<li>plugins/cli7zplugin/CMakeLists.txt <span style="color: grey">(3c114be)</span></li>
<li>plugins/cli7zplugin/kerfuffle_cli7z.desktop <span style="color: grey">(2c3db3a)</span></li>
<li>plugins/cli7zplugin/kerfuffle_cli7z.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/clilhaplugin/CMakeLists.txt <span style="color: grey">(54cec6b)</span></li>
<li>plugins/clilhaplugin/kerfuffle_clilha.desktop <span style="color: grey">(5db71f2)</span></li>
<li>plugins/clilhaplugin/kerfuffle_clilha.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/clirarplugin/CMakeLists.txt <span style="color: grey">(9fb2a8e)</span></li>
<li>plugins/clirarplugin/kerfuffle_clirar.desktop <span style="color: grey">(ab6ae21)</span></li>
<li>plugins/clirarplugin/kerfuffle_clirar.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/clizipplugin/CMakeLists.txt <span style="color: grey">(37e51d4)</span></li>
<li>plugins/clizipplugin/kerfuffle_clizip.desktop <span style="color: grey">(472fbb5)</span></li>
<li>plugins/clizipplugin/kerfuffle_clizip.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/karchiveplugin/CMakeLists.txt <span style="color: grey">(7c6bf40)</span></li>
<li>plugins/karchiveplugin/kerfuffle_karchive.desktop <span style="color: grey">(8ee4c65)</span></li>
<li>plugins/karchiveplugin/kerfuffle_karchive.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/libarchive/CMakeLists.txt <span style="color: grey">(d0a03db)</span></li>
<li>plugins/libarchive/kerfuffle_libarchive.desktop <span style="color: grey">(38cf3d2)</span></li>
<li>plugins/libarchive/kerfuffle_libarchive.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/libarchive/kerfuffle_libarchive_readonly.desktop.cmake <span style="color: grey">(793f49f)</span></li>
<li>plugins/libsinglefileplugin/CMakeLists.txt <span style="color: grey">(f2399f1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102803/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>