Review Request: Bring karchive plugin in a better shape

Theofilos Intzoglou int.teo at gmail.com
Sun Oct 23 11:02:53 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102785/
-----------------------------------------------------------

(Updated Oct. 23, 2011, 11:02 a.m.)


Review request for KDE Utils and Raphael Kubo da Costa.


Changes
-------

I used the code from permissionsString. I just removed the part for the ACL permissions as there is no mention in the zip specification for ACL and also KArchive doesn't check for ACL.


Description
-------

* Make karchive plugin compilable again
* If there was a directory inside the archive the file size wasn't shown
* Convert file permissions to a readable string


Diffs (updated)
-----

  plugins/karchiveplugin/karchiveplugin.h eb08de9 
  plugins/karchiveplugin/karchiveplugin.cpp 330e002 

Diff: http://git.reviewboard.kde.org/r/102785/diff/diff


Testing
-------


Thanks,

Theofilos Intzoglou

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111023/cf462e98/attachment.html>


More information about the Kde-utils-devel mailing list