Review Request: Bring karchive plugin in a better shape

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102785/#review7542
-----------------------------------------------------------


Please take care of the trailing whitespace as well.


plugins/karchiveplugin/karchiveplugin.h
<http://git.reviewboard.kde.org/r/102785/#comment6525>

    Hmm, it's a shame we can't use KFileItem::permissionsString() here.
    
    By the way, this is also a better name for this method, and you can borrow the implementation from KFileItem.



plugins/karchiveplugin/karchiveplugin.cpp
<http://git.reviewboard.kde.org/r/102785/#comment6522>

    Q_UNUSED already expands to a call with a trailing ';', so the one here can be removed.



plugins/karchiveplugin/karchiveplugin.cpp
<http://git.reviewboard.kde.org/r/102785/#comment6523>

    Ditto.


- Raphael Kubo da Costa


On Oct. 5, 2011, 4:16 p.m., Theofilos Intzoglou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102785/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2011, 4:16 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> * Make karchive plugin compilable again
> * If there was a directory inside the archive the file size wasn't shown
> * Convert file permissions to a readable string
> 
> 
> Diffs
> -----
> 
>   plugins/karchiveplugin/karchiveplugin.h eb08de9 
>   plugins/karchiveplugin/karchiveplugin.cpp 330e002 
> 
> Diff: http://git.reviewboard.kde.org/r/102785/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Theofilos Intzoglou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111022/cefec272/attachment.html>