Review Request: Fix crashes when closing ark during large archive loading.

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102903/#review7545
-----------------------------------------------------------


Thanks a lot for looking into this ugly issue :)

This patch is quite big and touches many core parts of the program.

I would really appreciate it if you split it into smaller review requests (for example, a patch moves the observer code around, the other changes the signals and slots, another one adds the prepareFoo methods, etc), each dealing with a separate part of the issue, explaining in more detail the reasons behind the changes. It makes it much easier to review, and easier to revert parts of it in case something breaks.

You also need to rebase it on top of trunk -- the current patch reverts some commits which have been made lately. And please do not introduce trailing whitespace in the changes.

- Raphael Kubo da Costa


On Oct. 18, 2011, 12:24 a.m., Michal Sciubidlo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102903/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2011, 12:24 a.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> When ark closes fastKill signal is send to any job that is in progress.
> CliInterface process it, kills process and quits.
> LibArchiveInterface processEvents and quits after fastKill signal.
> 
> 
> This addresses bug 193908.
>     http://bugs.kde.org/show_bug.cgi?id=193908
> 
> 
> Diffs
> -----
> 
>   kerfuffle/archivebase.cpp f274da5 
>   kerfuffle/archiveinterface.h 86cc8e4 
>   kerfuffle/archiveinterface.cpp 16b2455 
>   kerfuffle/cliinterface.h 2d4187c 
>   kerfuffle/cliinterface.cpp 90f77f2 
>   kerfuffle/jobs.h 13c0494 
>   kerfuffle/jobs.cpp 781920f 
>   plugins/clizipplugin/cliplugin.cpp 23c77ef 
>   plugins/karchiveplugin/karchiveplugin.cpp 330e002 
>   plugins/libarchive/libarchivehandler.h 9ec7541 
>   plugins/libarchive/libarchivehandler.cpp ff711f4 
>   plugins/libsinglefileplugin/singlefileplugin.h 67676e1 
>   plugins/libsinglefileplugin/singlefileplugin.cpp e5aaf2a 
> 
> Diff: http://git.reviewboard.kde.org/r/102903/diff/diff
> 
> 
> Testing
> -------
> 
> opening tar.bz2, zip and closing ark during it. creating zip, tar.bz2.
> 
> 
> Thanks,
> 
> Michal Sciubidlo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111022/cfccf609/attachment.html>