<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102903/">http://git.reviewboard.kde.org/r/102903/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks a lot for looking into this ugly issue :)
This patch is quite big and touches many core parts of the program.
I would really appreciate it if you split it into smaller review requests (for example, a patch moves the observer code around, the other changes the signals and slots, another one adds the prepareFoo methods, etc), each dealing with a separate part of the issue, explaining in more detail the reasons behind the changes. It makes it much easier to review, and easier to revert parts of it in case something breaks.
You also need to rebase it on top of trunk -- the current patch reverts some commits which have been made lately. And please do not introduce trailing whitespace in the changes.</pre>
<br />
<p>- Raphael</p>
<br />
<p>On October 18th, 2011, 12:24 a.m., Michal Sciubidlo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Michal Sciubidlo.</div>
<p style="color: grey;"><i>Updated Oct. 18, 2011, 12:24 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When ark closes fastKill signal is send to any job that is in progress.
CliInterface process it, kills process and quits.
LibArchiveInterface processEvents and quits after fastKill signal.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">opening tar.bz2, zip and closing ark during it. creating zip, tar.bz2.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=193908">193908</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kerfuffle/archivebase.cpp <span style="color: grey">(f274da5)</span></li>
<li>kerfuffle/archiveinterface.h <span style="color: grey">(86cc8e4)</span></li>
<li>kerfuffle/archiveinterface.cpp <span style="color: grey">(16b2455)</span></li>
<li>kerfuffle/cliinterface.h <span style="color: grey">(2d4187c)</span></li>
<li>kerfuffle/cliinterface.cpp <span style="color: grey">(90f77f2)</span></li>
<li>kerfuffle/jobs.h <span style="color: grey">(13c0494)</span></li>
<li>kerfuffle/jobs.cpp <span style="color: grey">(781920f)</span></li>
<li>plugins/clizipplugin/cliplugin.cpp <span style="color: grey">(23c77ef)</span></li>
<li>plugins/karchiveplugin/karchiveplugin.cpp <span style="color: grey">(330e002)</span></li>
<li>plugins/libarchive/libarchivehandler.h <span style="color: grey">(9ec7541)</span></li>
<li>plugins/libarchive/libarchivehandler.cpp <span style="color: grey">(ff711f4)</span></li>
<li>plugins/libsinglefileplugin/singlefileplugin.h <span style="color: grey">(67676e1)</span></li>
<li>plugins/libsinglefileplugin/singlefileplugin.cpp <span style="color: grey">(e5aaf2a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102903/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>