Review Request: Internal viewer: remember and restore the size last used

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103581/#review9397
-----------------------------------------------------------

Ship it!


Looks fine, thanks! Please fix the nitpicks below and commit to both KDE/4.8 and master.


part/arkviewer.cpp
<http://git.reviewboard.kde.org/r/103581/#comment7742>

    This block of commented out lines can be removed.



part/arkviewer.cpp
<http://git.reviewboard.kde.org/r/103581/#comment7741>

    Coding style: return foo; instead of return (foo);


- Raphael Kubo da Costa


On Dec. 30, 2011, 8:14 a.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103581/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2011, 8:14 a.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> The internal file viewer is always created with a fixed size in ArkViewer::viewInInternalViewer(), there is a TODO comment in the code saying that the size should be saved and restored in the config file.  This patch implements that.
> 
> The sizeHint of the dialog is set to the original default size.  This is so that the viewer opens at a sensible size the first time that Ark is run, but it is ignored if there is a saved size.  (Ignore diff v1, had forgotten to include this.)
> 
> 
> Diffs
> -----
> 
>   part/arkviewer.h b810e17 
>   part/arkviewer.cpp 9bfd651 
> 
> Diff: http://git.reviewboard.kde.org/r/103581/diff/diff
> 
> 
> Testing
> -------
> 
> Built Ark with these changes, checked operation of internal viewer and that the size is correctly set initially and restored.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111231/b968285c/attachment.html>