Review Request: Internal viewer: remember and restore the size last used

Jonathan Marten jjm at keelhaul.me.uk
Fri Dec 30 08:14:33 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103581/
-----------------------------------------------------------

Review request for KDE Utils and Raphael Kubo da Costa.


Description
-------

The internal file viewer is always created with a fixed size in ArkViewer::viewInInternalViewer(), there is a TODO comment in the code saying that the size should be saved and restored in the config file.  This patch implements that.

The sizeHint of the dialog is set to the original default size.  This is so that the viewer opens at a sensible size the first time that Ark is run, but it is ignored if there is a saved size.  (Ignore diff v1, had forgotten to include this.)


Diffs
-----

  part/arkviewer.h b810e17 
  part/arkviewer.cpp 9bfd651 

Diff: http://git.reviewboard.kde.org/r/103581/diff/diff


Testing
-------

Built Ark with these changes, checked operation of internal viewer and that the size is correctly set initially and restored.


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111230/2fa8b8f4/attachment.html>


More information about the Kde-utils-devel mailing list