[patch] new entries in kwalletmanager

[Rolf Eike Beer]

Am Dienstag, 29. April 2008 schrieb Michael Leupold:
> Hi Eike,
>
> Am Dienstag, 29. April 2008 schrieb Rolf Eike Beer:
> > > So, this is my first try at a patch to
> > > kdeutils/kwallet/kwalleteditor.cpp
> >
> > Sounds basically ok. What I'm wondering about: don't we need a "delete
> > ni;" in line 697 of the original file?
>
> As far as I know we don't. KWalletEntryItem's constructor already added the
> new item to the list (and parented it), so it gets destructed properly when
> the list is destructed. So we don't "need" to.

It's not a ressource leak, that's correct.

> Still I guess deleting might be a better choice as the current behaviour
> might confuse the user (error message and entry still shown).

Exactly.

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-utils-devel/attachments/20080429/b24d5f96/attachment.pgp