Review Request 129016: [ktp-auth-handler] Fixed uninitialized variable usage

Alexandr Akulich akulichalexander at gmail.com
Mon Sep 26 07:55:52 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129016/
-----------------------------------------------------------

(Updated Sept. 26, 2016, 7:55 a.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy and Aleix Pol Gonzalez.


Changes
-------

Submitted with commit 03508d05afe02c17ed7066d78d6f42283c2e14e5 by Alexandr Akulich to branch master.


Repository: ktp-auth-handler


Description
-------

If there is no account (condition at 175 is false), then ```SignOn::Identity *identity``` will be used without initialization at line 210.

Bug reported by the clang static analyzer.

Thanks to Aleix Pol Gonzalez for the idea to run the analyzer. :)


Diffs
-----

  x-telepathy-password-auth-operation.cpp be0ed99 

Diff: https://git.reviewboard.kde.org/r/129016/diff/


Testing
-------

Compiles


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160926/cb3e5fc3/attachment.html>


More information about the KDE-Telepathy mailing list