Review Request 129016: [ktp-auth-handler] Fixed uninitialized variable usage

David Huffman dhuffman at linux.com
Mon Sep 26 02:08:02 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129016/#review99521
-----------------------------------------------------------


Ship it!




Ship It!

- David Huffman


On Sept. 25, 2016, 1:33 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129016/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2016, 1:33 p.m.)
> 
> 
> Review request for Telepathy and Aleix Pol Gonzalez.
> 
> 
> Repository: ktp-auth-handler
> 
> 
> Description
> -------
> 
> If there is no account (condition at 175 is false), then ```SignOn::Identity *identity``` will be used without initialization at line 210.
> 
> Bug reported by the clang static analyzer.
> 
> Thanks to Aleix Pol Gonzalez for the idea to run the analyzer. :)
> 
> 
> Diffs
> -----
> 
>   x-telepathy-password-auth-operation.cpp be0ed99 
> 
> Diff: https://git.reviewboard.kde.org/r/129016/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160926/2f01a45b/attachment-0001.html>


More information about the KDE-Telepathy mailing list