Review Request 128841: Fix message classes for history items

Mariusz Glebocki mglb at arccos-1.net
Thu Sep 8 21:56:33 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128841/
-----------------------------------------------------------

(Updated Sept. 8, 2016, 11:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Changes
-------

Submitted with commit 7e429544a6f5530365c22ca5f83b4fc4e97de658 by Alexandr Akulich on behalf of Mariusz Glebocki to branch master.


Bugs: 348929
    http://bugs.kde.org/show_bug.cgi?id=348929


Repository: ktp-text-ui


Description
-------

"incoming" and "outgoing" classes for history messages are swapped - they are used for local to remote and remote to local messages, respectively. This bug is visible in styles that use a single .html file for sent and received messages, relying on a class.
I don't know which theme could be used to test it - I spotted this while playing with theme creation. Everything without an "Outgoing" directory and with distinguishable incoming/outgoing messages should be ok.


Diffs
-----

  lib/adium-theme-message-info.cpp ce1d5cd 

Diff: https://git.reviewboard.kde.org/r/128841/diff/


Testing
-------

- compile/run: OK
- talk with someone, close the window, open the chat again, check the last chat message's direction: OK


Thanks,

Mariusz Glebocki

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160908/47bd169e/attachment.html>


More information about the KDE-Telepathy mailing list