Review Request 128841: Fix message classes for history items

[Alexandr Akulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128841/#review98911
-----------------------------------------------------------


Ship it!




Thank you! You fixed a known bug:
https://bugs.kde.org/show_bug.cgi?id=348929

- Alexandr Akulich


On Sept. 6, 2016, 1:17 a.m., Mariusz Glebocki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128841/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 1:17 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> "incoming" and "outgoing" classes for history messages are swapped - they are used for local to remote and remote to local messages, respectively. This bug is visible in styles that use a single .html file for sent and received messages, relying on a class.
> I don't know which theme could be used to test it - I spotted this while playing with theme creation. Everything without an "Outgoing" directory and with distinguishable incoming/outgoing messages should be ok.
> 
> 
> Diffs
> -----
> 
>   lib/adium-theme-message-info.cpp ce1d5cd 
> 
> Diff: https://git.reviewboard.kde.org/r/128841/diff/
> 
> 
> Testing
> -------
> 
> - compile/run: OK
> - talk with someone, close the window, open the chat again, check the last chat message's direction: OK
> 
> 
> Thanks,
> 
> Mariusz Glebocki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160905/33256620/attachment.html>