Review Request 128807: [k-c-i/kpeople] Final initialization step moved from loadCache to constructor

Alexandr Akulich akulichalexander at gmail.com
Tue Sep 6 09:22:48 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128807/
-----------------------------------------------------------

(Updated Sept. 6, 2016, 11:22 a.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Changes
-------

Submitted with commit 3989778fafde7fbf8bf2e4b7b439a0b401050187 by Alexandr Akulich to branch master.


Repository: ktp-common-internals


Description
-------

The moved code should be called just once on construction and *not* on each cache load (which is called on (any) account presence changed to offline).

I removed Qt::UniqueConnection argument, because it is not needed anymore.


Diffs
-----

  kpeople/datasourceplugin/im-persons-data-source.cpp 7f1d08e 

Diff: https://git.reviewboard.kde.org/r/128807/diff/


Testing
-------

Works


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160906/0c393fbb/attachment.html>


More information about the KDE-Telepathy mailing list