Review Request 128807: [k-c-i/kpeople] Final initialization step moved from loadCache to constructor

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128807/#review98815
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On Aug. 31, 2016, 4:43 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128807/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2016, 4:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> The moved code should be called just once on construction and *not* on each cache load (which is called on (any) account presence changed to offline).
> 
> I removed Qt::UniqueConnection argument, because it is not needed anymore.
> 
> 
> Diffs
> -----
> 
>   kpeople/datasourceplugin/im-persons-data-source.cpp 7f1d08e 
> 
> Diff: https://git.reviewboard.kde.org/r/128807/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160901/7f1e057a/attachment.html>