Review Request 127189: ktp-contact-list offline-on-close fix.

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127189/
-----------------------------------------------------------

(Updated March 13, 2016, 3:19 a.m.)


Review request for Telepathy.


Changes
-------

Finish removing goOffline().


Repository: ktp-contact-list


Description
-------

Fixes offline-on-close.
-Remove goOffline(), call setPresence() directly.

The check for qApp->closingDown() doesn't appear required, and removing it is needed for the global presence to change offline on close.

Applies to #123487, which already has GlobalPresence for offline-on-close as a requirement for multiple account presence setting.


Diffs (updated)
-----

  main-widget.h 43334ef8442217154f0df198ce601c9b996914d9 
  main-widget.cpp e0982594ac4c05b84db5772722b98b733410752b 

Diff: https://git.reviewboard.kde.org/r/127189/diff/


Testing
-------

Compile, run. This doesn't ask for me, but does go offline when it's supposed to.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160313/0b27878b/attachment-0001.html>