Review Request 127189: ktp-contact-list offline-on-close fix.

[Martin Klapetek]

> On Feb. 29, 2016, 8:46 p.m., Martin Klapetek wrote:
> > So what happens when you don't have any applet and close the contact list window?
> 
> James Smith wrote:
>     Offline.

That's a step back from the current state.

I don't see why we should want that?

(you're not really explaining the _why_ parts of your changes very well)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127189/#review92929
-----------------------------------------------------------


On March 7, 2016, 8:10 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127189/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 8:10 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> -Remove Presence Applet cruft.
> -Remove goOffline(), call setPresence() directly.
> 
> The check for qApp->closingDown() doesn't appear required, and removing it is needed for the global presence to change offline on close.
> 
> Applies to #123487, which already has GlobalPresence for offline-on-close as a requirement for multiple account presence setting.
> 
> 
> Diffs
> -----
> 
>   main-widget.h 43334ef8442217154f0df198ce601c9b996914d9 
>   main-widget.cpp e0982594ac4c05b84db5772722b98b733410752b 
> 
> Diff: https://git.reviewboard.kde.org/r/127189/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160307/ff1849ca/attachment.html>