Review Request 123487: ktp-contact-list status handler multiple account presence changes

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123487/
-----------------------------------------------------------

(Updated March 12, 2016, 7:43 a.m.)


Review request for Telepathy.


Changes
-------

Update for StatusHandlerPresence changes.
1)The advanced presence dialog now requests the account presence by StatusHandlerPresence, and uses setRequestedPresence() if that fails. This has a few advantages, like properly removing the
account presence (when placing the account presence in global presence mode when the existing account presence is the same as the existing global presence) without first setting the account offline, avoiding one unneccessary change event (or if there are PluginQueue plugins active, a total of two avoided requested presence change events) Normally with e.g. the now playing plugin active, this avoids one requested presence change that the AccountStatusHelper would do to catch up.


Bugs: 181748
    http://bugs.kde.org/show_bug.cgi?id=181748


Repository: ktp-contact-list


Description
-------

New classes:
AdvancedPresenceDialog, a dialog for advanced presence setting.

New features:
-GlobalPresenceChooser uses StatusHandlerPresence to enable PluginQueue plugins, and quick status message changes if the status handler is available.
-GlobalPresence is implemented for offline-on-close.


Diffs (updated)
-----

  CMakeLists.txt db1ec2ead08daf7176d8e1d014a80d5af249b222 
  dialogs/advanced-presence-dialog.h PRE-CREATION 
  dialogs/advanced-presence-dialog.cpp PRE-CREATION 
  global-presence-chooser.h f07b8823077e1558047ce019f13e619ca6b432c3 
  global-presence-chooser.cpp 323217c82a4ba9f139f38a26734e152915147c25 
  main-widget.h 43334ef8442217154f0df198ce601c9b996914d9 
  main-widget.cpp e0982594ac4c05b84db5772722b98b733410752b 

Diff: https://git.reviewboard.kde.org/r/123487/diff/


Testing
-------

Compile, run.


File Attachments
----------------

Advanced Presence Setting option
  https://git.reviewboard.kde.org/media/uploaded/files/2016/02/06/0f7aa5e8-c3a5-4d2f-9549-32531cddd009__advancedpresencedialogoption.png
Advanced Presence Setting dialog
  https://git.reviewboard.kde.org/media/uploaded/files/2016/02/17/b9c5741d-89f6-48f7-887c-68ebffb737c4__advancedpresencedialog.png
Advanced Presence Setting dialog editing status message
  https://git.reviewboard.kde.org/media/uploaded/files/2016/02/17/6b368cf1-426e-41da-910e-a732463c42c1__advancedpresencedialogstatusmessage.png


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160312/2f45179c/attachment.html>