<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123487/">https://git.reviewboard.kde.org/r/123487/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated March 12, 2016, 7:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Update for StatusHandlerPresence changes.
1)The advanced presence dialog now requests the account presence by StatusHandlerPresence, and uses setRequestedPresence() if that fails. This has a few advantages, like properly removing the
account presence (when placing the account presence in global presence mode when the existing account presence is the same as the existing global presence) without first setting the account offline, avoiding one unneccessary change event (or if there are PluginQueue plugins active, a total of two avoided requested presence change events) Normally with e.g. the now playing plugin active, this avoids one requested presence change that the AccountStatusHelper would do to catch up.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=181748">181748</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-contact-list
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">New classes:
AdvancedPresenceDialog, a dialog for advanced presence setting.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">New features:
-GlobalPresenceChooser uses StatusHandlerPresence to enable PluginQueue plugins, and quick status message changes if the status handler is available.
-GlobalPresence is implemented for offline-on-close.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compile, run.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(db1ec2ead08daf7176d8e1d014a80d5af249b222)</span></li>
<li>dialogs/advanced-presence-dialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>dialogs/advanced-presence-dialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>global-presence-chooser.h <span style="color: grey">(f07b8823077e1558047ce019f13e619ca6b432c3)</span></li>
<li>global-presence-chooser.cpp <span style="color: grey">(323217c82a4ba9f139f38a26734e152915147c25)</span></li>
<li>main-widget.h <span style="color: grey">(43334ef8442217154f0df198ce601c9b996914d9)</span></li>
<li>main-widget.cpp <span style="color: grey">(e0982594ac4c05b84db5772722b98b733410752b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123487/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/06/0f7aa5e8-c3a5-4d2f-9549-32531cddd009__advancedpresencedialogoption.png">Advanced Presence Setting option</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/17/b9c5741d-89f6-48f7-887c-68ebffb737c4__advancedpresencedialog.png">Advanced Presence Setting dialog</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/17/6b368cf1-426e-41da-910e-a732463c42c1__advancedpresencedialogstatusmessage.png">Advanced Presence Setting dialog editing status message</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>