Review Request 128525: [Quick Chat] Fix looping over dropped URLs
Kai Uwe Broulik
kde at privat.broulik.de
Tue Jul 26 09:16:06 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128525/
-----------------------------------------------------------
(Updated July 26, 2016, 9:16 a.m.)
Status
------
This change has been marked as submitted.
Review request for Telepathy.
Changes
-------
Submitted with commit df50ef74bc37befca8eee3ecefcb9871df1621b9 by Kai Uwe Broulik to branch Applications/16.08.
Repository: ktp-desktop-applets
Description
-------
The for..in loop didn't properly iterate the array of URLs (JavaScript...), replacing it by a traditional for loop fixes file transfers.
Diffs
-----
chat/org.kde.ktp-chat/contents/ui/ConversationDelegateButton.qml 79b4f4a
Diff: https://git.reviewboard.kde.org/r/128525/diff/
Testing
-------
Together with Review 128524 this fixes dropping files onto chat icons in my panel to send files. Tested with both a single and multiple files.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160726/3546804a/attachment.html>
More information about the KDE-Telepathy
mailing list