Review Request 128525: [Quick Chat] Fix looping over dropped URLs

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128525/#review97849
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On July 26, 2016, 10:49 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128525/
> -----------------------------------------------------------
> 
> (Updated July 26, 2016, 10:49 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> The for..in loop didn't properly iterate the array of URLs (JavaScript...), replacing it by a traditional for loop fixes file transfers.
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ConversationDelegateButton.qml 79b4f4a 
> 
> Diff: https://git.reviewboard.kde.org/r/128525/diff/
> 
> 
> Testing
> -------
> 
> Together with Review 128524 this fixes dropping files onto chat icons in my panel to send files. Tested with both a single and multiple files.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160726/84923ce6/attachment.html>