Review Request 128460: ktp-text-ui: Added a filter for geo uri support

[Alexandr Akulich]

> On July 15, 2016, 3:57 p.m., Aleix Pol Gonzalez wrote:
> > I really like the idea!

Thanks!


I have no idea how to implement other multimedia messages with current KTp::Message API.
Locally I changed it to pass all MessageParts (currently we have only text), and may be I would come with bolder changes next month or two. :)


> On July 15, 2016, 3:57 p.m., Aleix Pol Gonzalez wrote:
> > filters/geopoint/geopoint-filter.cpp, line 34
> > <https://git.reviewboard.kde.org/r/128460/diff/1/?file=471790#file471790line34>
> >
> >     Can we maybe use something that is more free software friendly than Google Maps?

As I said, I tried OSM first, but not managed to make it to works in a hour, so I switched to Google Maps for the "prove of concept" at least.

I would try again to make it works with OSM after 5 August.


- Alexandr


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128460/#review97439
-----------------------------------------------------------


On July 15, 2016, 4:15 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128460/
> -----------------------------------------------------------
> 
> (Updated July 15, 2016, 4:15 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Added a geopoint filter which adds an iframe with a map for each geo:<double,double> in message (RFC 5870).
> 
> I tried to use openstreetmap, but had no success. I would like to add an option to select osm or google maps, but I have no time to do it now.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt 8118b13 
>   filters/geopoint/CMakeLists.txt PRE-CREATION 
>   filters/geopoint/geopoint-filter.h PRE-CREATION 
>   filters/geopoint/geopoint-filter.cpp PRE-CREATION 
>   filters/geopoint/ktptextui_message_filter_geopoint.desktop.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128460/diff/
> 
> 
> Testing
> -------
> 
> It works for me.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160715/4fc6ca83/attachment.html>